Add python serde support for varopt sketches#297
Merged
jmalkin merged 7 commits intoapache:masterfrom Aug 16, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 2752291174Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
added 2 commits
July 27, 2022 18:34
…d ctor with incorret use of filled_data_, and tidy up use of that flag.
AlexanderSaydakov
approved these changes
Aug 16, 2022
Contributor
AlexanderSaydakov
left a comment
AlexanderSaydakov
left a comment
There was a problem hiding this comment.
I don't think I completely understand how all this comes together, but looks fine to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The immediate result is for varopt, but having this working should be an important part of adding tuple support.
I'm least confident in the error recovery during deserialization. I think it's most likely that Python will throw an error which propagates through the c++ code. In this case I'm intercepting it to try to decrement reference counts for items we've already allocated but it's hard to tell if that's actually preventing a leak or not. Happy for suggestions on how to clean up that code.
Also, fixed a size bug in varopt.